[PATCH][net-next] net_sched: remove redundant assignment to ret

From: Colin King
Date: Fri Sep 29 2017 - 10:01:29 EST


From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

The assignment of -EINVAL to variable ret is redundant as it
is being overwritten on the following error exit paths or
to the return value from the following call to basic_set_parms.
Fix this up by removing it. Cleans up clang warning message:

net/sched/cls_basic.c:185:2: warning: Value stored to 'err' is never read

Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
net/sched/cls_basic.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
index cfeb6f158566..700b345b07f9 100644
--- a/net/sched/cls_basic.c
+++ b/net/sched/cls_basic.c
@@ -182,7 +182,6 @@ static int basic_change(struct net *net, struct sk_buff *in_skb,
if (err < 0)
goto errout;

- err = -EINVAL;
if (handle) {
fnew->handle = handle;
if (!fold) {
--
2.14.1