Re: [PATCH] mm: kill kmemcheck again

From: Steven Rostedt
Date: Sat Sep 30 2017 - 05:48:31 EST


On Wed, 27 Sep 2017 17:02:07 +0200
Michal Hocko <mhocko@xxxxxxxxxx> wrote:

> > Now that 2 years have passed, and all distros provide gcc that supports
> > KASAN, kill kmemcheck again for the very same reasons.
>
> This is just too large to review manually. How have you generated the
> patch?

I agree. This needs to be taken out piece by piece, not in one go,
where there could be unexpected fallout.

>
> My compile test batery failed for i386 allyesconfig for some reason
> which is not entirely clear to me (see attached). I have applied on top
> of dc972a67cc54585bd83ad811c4e9b6ab3dcd427e and that one compiles fine.
>
> > Cc: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> > Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> > Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
>
> Anyway I fully support this removal. It is a lot of rarely used code and
> KASAN is much more usable.

Now that my default compilers support KASAN, I'm fine with this removal.

-- Steve