Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.
From: Shreeya Patel
Date: Sat Sep 30 2017 - 07:14:01 EST
On Sat, 2017-09-30 at 21:06 +1000, Tobin C. Harding wrote:
> Hi Shreeya,
>
> We don't usually add a period to the subject line for kernel patches.
> (reason: we only have about
> 52 characters for the commit brief description so best not to waste
> any).
>
> On Sat, Sep 30, 2017 at 01:30:34PM +0530, Shreeya Patel wrote:
> >
> > This patch removes unnecessary comments which are there
> > to explain why call to memset is in comments. Both of the
> > comments are not needed as they are not very useful.
> You may like to read Documentation/process/submitting-patches.rst
> (specifically
> section 2) for tips on writing your git log.
>
> ÂÂÂÂÂÂÂÂDescribe your changes in imperative mood, e.g. "make xyzzy do
> frotz"
> ÂÂÂÂÂÂÂÂinstead of "[This patch] makes xyzzy do frotz" or "[I]
> changed xyzzy
> ÂÂÂÂÂÂÂÂto do frotz", as if you are giving orders to the codebase to
> change
> ÂÂÂÂÂÂÂÂits behaviour.
>
> Good luck,
> Tobin.
Hello,
Thanks for correcting me :)
I'll do the necessary changes and will send as v3.