Re: [PATCH] net: hns3: fix null pointer dereference before null check

From: David Miller
Date: Sat Sep 30 2017 - 23:13:14 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Fri, 29 Sep 2017 20:51:23 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> pointer ndev is being dereferenced with the call to netif_running
> before it is being null checked. Re-order the code to only dereference
> ndev after it has been null checked.
>
> Detected by CoverityScan, CID#1457206 ("Dereference before null check")
>
> Fixes: 9df8f79a4d29 ("net: hns3: Add DCB support when interacting with network stack")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied.