Re: [PATCH 10/10] [RFC] w1_netlink.h: add support for nested structs

[Evgeniy Polyakov]

Hi

26.09.2017, 20:59, "Mauro Carvalho Chehab" <mchehab@xxxxxxxxxxxxxxxx>:
> Describe nested struct/union fields
>
> NOTE: This is a pure test patch, meant to validate if the
> parsing logic for nested structs is working properly.
>
> I've no idea if the random text I added there is correct!

It looks correct, although I would switch master bus with bus master.

Feel free to add my acked-by.

> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>
> ---
> Âdrivers/w1/w1_netlink.h | 4 ++++
> Â1 file changed, 4 insertions(+)
>
> diff --git a/drivers/w1/w1_netlink.h b/drivers/w1/w1_netlink.h
> index a36661cd1f05..e781d1109cd7 100644
> --- a/drivers/w1/w1_netlink.h
> +++ b/drivers/w1/w1_netlink.h
> @@ -60,6 +60,10 @@ enum w1_netlink_message_types {
> ÂÂ* @status: kernel feedback for success 0 or errno failure value
> ÂÂ* @len: length of data following w1_netlink_msg
> ÂÂ* @id: union holding master bus id (msg.id) and slave device id (id[8]).
> + * @id.id: Slave ID (8 bytes)
> + * @id.mst: master bus identification
> + * @id.mst.id: master bus ID
> + * @id.mst.res: master bus reserved
> ÂÂ* @data: start address of any following data
> ÂÂ*
> ÂÂ* The base message structure for w1 messages over netlink.
> --
> 2.13.5