Re: [PATCH v1 1/2] ASoC: codecs: msm8916-wcd-analog: move pm8916_wcd_setup_mbhc

[Srinivas Kandagatla]

Thanks for the patch,

On 29/09/17 18:42, Damien Riegel wrote:
> In preparation of a fix for the initial detection of headset,
> pm8916_wcd_setup_mbhc is moved to be defined after
> pm8916_mbhc_configure_bias instead of before.
>
> Signed-off-by: Damien Riegel <damien.riegel@xxxxxxxxxxxxxxxxxxxx>
> ---
>   sound/soc/codecs/msm8916-wcd-analog.c | 88 +++++++++++++++++------------------
>   1 file changed, 44 insertions(+), 44 deletions(-)
I would suggest you to move this changes to second patch.

thanks,
srini

> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index f562f2d86907..9f08d998a79b 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -443,50 +443,6 @@ static int pm8916_wcd_analog_enable_micbias_int1(struct
>   						     wcd->micbias1_cap_mode);
>   }