Re: [Part2 PATCH v4 01/29] Documentation/virtual/kvm: Add AMD Secure Encrypted Virtualization (SEV)

From: Borislav Petkov
Date: Mon Oct 02 2017 - 09:21:48 EST

On Mon, Oct 02, 2017 at 06:52:01AM -0500, Brijesh Singh wrote:
> Thank you for the patch. One of feedback in RFC patches was to put the
> command id and their definitions in amd-memory-encryption.txt hence I
> was trying to follow that recommendation. Most of ioctls I have seen in
> api.txt are either common or architecture specific. These commands are
> vendor specific and I was not sure if they belong to api.txt. I am okay
> with moving the definition to api.txt in next patch and we can see if
> kvm folks have any objections.

So api.txt has them all and this way you can grep them easily. Much
better than spreading stuff around.

But looking at it again, you have the actual ioctls
which are API so you could keep only those in api.txt but
add a sentence there saying that the commands are defined in

> The series does not implement the migration commands yet hence I took it
> off.



SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)