Re: [PATCH v2 2/2] dt-bindings: i2c: Update documentation for "mv78230-a0-i2c"
From: Gregory CLEMENT
Date: Mon Oct 02 2017 - 10:23:58 EST
On ven., sept. 29 2017, Kalyan Kinthada <kalyan.kinthada@xxxxxxxxxxxxxxxxxxx> wrote:
> This commit modifies the documentation for
> "marvell,mv78230-a0-i2c" compatible string.
> The "marvell,mv78230-a0-i2c" compatible string enables the workaround
> for an i2c repeated start timing violation, but unlike
> "marvell,mv78230-i2c" it disables the i2c offload support. This is
> applicable to a number of SoCs such as early revisions of the Armada XP
> and the Armada 38x.
> Signed-off-by: Kalyan Kinthada <kalyan.kinthada@xxxxxxxxxxxxxxxxxxx>
I applied the dt fix on my mvebu/fixes branch. Do you want to apply this
one on your branch, or do you prefer I take it. In this case an acked-by
would be nice.
> Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> index 5c30026921ae..c6cbab17ed0a 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> @@ -10,10 +10,12 @@ Required properties :
> - "marvell,mv64xxx-i2c"
> - "marvell,mv78230-i2c"
> - "marvell,mv78230-a0-i2c"
> - * Note: Only use "marvell,mv78230-a0-i2c" for a
> - very rare, initial version of the SoC which
> - had broken offload support. Linux
> - auto-detects this and sets it appropriately.
> + * Note: Use "marvell,mv78230-a0-i2c" for
> + controller which do not support offload
> + but still have the i2c repeated start
> + timing violation issue, such as the
> + ones found in the Armada XP A0 and the
> + Armada 38x SoCs.
> - interrupts : The interrupt number
> Optional properties :
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.