Re: [PATCH] vfio-mdev: make mdev_fops const and static

[Alex Williamson]

On Sat, 30 Sep 2017 21:47:24 +0530
Bhumika Goyal <bhumirks@xxxxxxxxx> wrote:

> Make this const as it is only passed to a const argument of the function
> mdev_register_device. Make it static as it is not referenced in any
> other file.
> 
> Structure found using Coccinelle and changes done by hand.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@xxxxxxxxx>
> ---
>  samples/vfio-mdev/mtty.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
> index ca49568..09f255b 100644
> --- a/samples/vfio-mdev/mtty.c
> +++ b/samples/vfio-mdev/mtty.c
> @@ -1413,7 +1413,7 @@ struct attribute_group *mdev_type_groups[] = {
>  	NULL,
>  };
>  
> -struct mdev_parent_ops mdev_fops = {
> +static const struct mdev_parent_ops mdev_fops = {
>  	.owner                  = THIS_MODULE,
>  	.dev_attr_groups        = mtty_dev_groups,
>  	.mdev_attr_groups       = mdev_dev_groups,

Applied to vfio next branch for v4.15.  Thanks,

Alex