Re: [PATCH v3 05/14] drm/sun4i: hdmi: Disable clks in bind function error path and unbind function
From: Maxime Ripard
Date: Mon Oct 02 2017 - 16:02:45 EST
On Fri, Sep 29, 2017 at 08:22:57AM +0000, Chen-Yu Tsai wrote:
> The HDMI driver enables the bus and mod clocks in the bind function, but
> does not disable them if it then bails our due to any errors. Neither
> does it disable the clocks in the unbind function.
> Fix this by adding a proper error path to the bind function, and
> clk_disable_unprepare calls to the unbind function.
> Also rename the err_cleanup_connector label to err_cleanup_encoder,
> since it is the encoder that gets cleaned up.
> Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support")
> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>
> Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
Description: PGP signature