Re: Modular BIG_KEYS (was: Re: [PATCH v4] security/keys: rewrite all of big_key crypto)

From: David Howells
Date: Mon Oct 02 2017 - 17:12:16 EST


Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

> Now this has hit mainline, the "BIG_KEYS" Kconfig symbol appeared on my
> radar. Is there any reason this cannot be tristate?

It was tristate, but it got converted to bool:

commit 2eaf6b5dcafda2b8c22930eff7f48a364fce1741
KEYS: Make BIG_KEYS boolean

and then:

commit a1f2bdf338f15dbad10ee6362891ebf79244858b
security/keys: make big_key.c explicitly non-modular

> So to save kernel size, I wan't to save N, but for a distro kernel that might
> have Kerberos users, you currently need to say Y, while M would be nicer.

If you want to do that, you'll need to implement demand-loading of key type
modules.

Note that you'd end up using a minimum of a whole page as a module rather than
~2K if built in (I know, that's a compromise you have to decide on).

David