Re: [PATCH] fsl/fman: remove of_node

From: David Miller
Date: Mon Oct 02 2017 - 19:04:53 EST

From: Madalin Bucur <madalin.bucur@xxxxxxx>
Date: Mon, 2 Oct 2017 13:31:37 +0300

> The FMan MAC driver allocates a platform device for the Ethernet
> driver to probe on. Setting pdev->dev.of_node with the MAC node
> triggers the MAC driver probing of the new platform device. While
> this fails quickly and does not affect the functionality of the
> drivers, it is incorrect and must be removed. This was added to
> address a report that DSA code using of_find_net_device_by_node()
> is unable to use the DPAA interfaces. Error message seen before
> this fix:
> fsl_mac dpaa-ethernet.0: __devm_request_mem_region(mac) failed
> fsl_mac: probe of dpaa-ethernet.0 failed with error -16
> Signed-off-by: Madalin Bucur <madalin.bucur@xxxxxxx>

Is the DSA issue no longer something we need to be concerned
about? If not, why? You have to explain this.