[PATCH 4.9 37/64] iw_cxgb4: remove the stid on listen create failure

From: Greg Kroah-Hartman
Date: Tue Oct 03 2017 - 08:25:30 EST

4.9-stable review patch. If anyone has any objections, please let me know.


From: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>

commit 8b1bbf36b7452c4acb20e91948eaa5e225ea6978 upstream.

If a listen create fails, then the server tid (stid) is incorrectly left
in the stid idr table, which can cause a touch-after-free if the stid
is looked up and the already freed endpoint is touched. So make sure
and remove it in the error path.

Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Doug Ledford <dledford@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/infiniband/hw/cxgb4/cm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -3441,7 +3441,7 @@ int c4iw_create_listen(struct iw_cm_id *
cm_id->provider_data = ep;
goto out;
+ remove_handle(ep->com.dev, &ep->com.dev->stid_idr, ep->stid);
cxgb4_free_stid(ep->com.dev->rdev.lldi.tids, ep->stid,