Re: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE
From: Colin Ian King
Date: Tue Oct 03 2017 - 08:34:51 EST
On 03/10/17 12:39, Rafael J. Wysocki wrote:
> On Tuesday, October 3, 2017 3:16:22 AM CEST Jérémy Lefaure wrote:
>> On Mon, 02 Oct 2017 14:27:52 +0200
>> "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx> wrote:
>>> ACPICA is soewhat special code, though and I'm not taking or ACKing patches
>>> for it directly as a rule.
>>> For one, I'm not sure if ACPICA can use ARRAY_SIZE at all.
>> Why is it special code that can't use ARRAY_SIZE ? Is it because this
>> macro is defined in linux/kernel.h ?
However, ACPICA does have ACPI_ARRAY_LENGTH(x), see source/include/actypes.h
> Basically, yes.
> ACPICA is a separate project and the kernel acquires its source code from
> the upstream (which is used by other OSes too). That is not the case for
> any other code in the kernel I know about.
> We strive to keep the ACPICA code in the kernel as close to the upstream as
> reasonably possible for maintenance reasons, so we avoid doing Linux-specific
> things in it.
> As a rule of thumb, if you do cleanups like this one, better avoid the ACPICA
> code. :-)
> Devel mailing list