Re: [PATCH] DT/arm,gic-v3: Update the ITS size in the examples

From: Mark Rutland
Date: Tue Oct 03 2017 - 10:55:08 EST


On Tue, Oct 03, 2017 at 03:20:27PM +0100, Julien Grall wrote:
> Currently, the examples are using 2MB for the ITS size. Per the
> specification (section 8.18 in ARM IHI 0069D), the ITS address map is
> 128KB.
>
> Update the examples to match the specification.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

This looks sane to me, per my reading of that section of the spec.

Marc, was there some reason we used such a large size? Or was the extra
zero unintentional?

Thanks,
Mark.

> ---
> .../devicetree/bindings/interrupt-controller/arm,gic-v3.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> index 4c29cdab0ea5..5eb108e180fa 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> @@ -99,7 +99,7 @@ Examples:
> compatible = "arm,gic-v3-its";
> msi-controller;
> #msi-cells = <1>;
> - reg = <0x0 0x2c200000 0 0x200000>;
> + reg = <0x0 0x2c200000 0 0x20000>;
> };
> };
>
> @@ -124,14 +124,14 @@ Examples:
> compatible = "arm,gic-v3-its";
> msi-controller;
> #msi-cells = <1>;
> - reg = <0x0 0x2c200000 0 0x200000>;
> + reg = <0x0 0x2c200000 0 0x20000>;
> };
>
> gic-its@2c400000 {
> compatible = "arm,gic-v3-its";
> msi-controller;
> #msi-cells = <1>;
> - reg = <0x0 0x2c400000 0 0x200000>;
> + reg = <0x0 0x2c400000 0 0x20000>;
> };
>
> ppi-partitions {
> --
> 2.11.0
>