Re: [RFC 5/5] pm: remove kernel thread freezing
From: Luis R. Rodriguez
Date: Tue Oct 03 2017 - 16:27:45 EST
On Tue, Oct 03, 2017 at 08:21:42PM +0000, Bart Van Assche wrote:
> On Tue, 2017-10-03 at 22:17 +0200, Jiri Kosina wrote:
> > On Tue, 3 Oct 2017, Bart Van Assche wrote:
> > > What about the many drivers outside filesystems that use the
> > > set_freezable() / try_to_freeze() / wait_event_freezable() API?
> > Many/most of them are just completely bogus and pointless. I've killed a
> > lot of those in the past, but the copy/paste programming is just too
> > strong enemy to fight against.
> If just a single driver would use that API to prevent that I/O occurs while
> processes are frozen then this patch will break that driver.
Yes! And although as Jiri points out, its debatable where this is being used,
but as you suggest there may be *valid* reasons for it *now* even though
originally it *may* have been bogus...
Its why I believe this now can only be done piecemeal wise, slowly but steady.
To avoid regressions, and make this effort bisectable.