Re: [PATCH 2/8] ARM: dts: aspeed: Reorder ADC node

[Andrew Jeffery]

On Thu, 2017-09-28 at 17:21 +0930, Joel Stanley wrote:
> We try to keep the nodes in address order. The ADC node was out of
> place.
>Â
> Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
> ---
> Âarch/arm/boot/dts/aspeed-g4.dtsi | 16 ++++++++--------
> Âarch/arm/boot/dts/aspeed-g5.dtsi | 16 ++++++++--------
> Â2 files changed, 16 insertions(+), 16 deletions(-)
>Â
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index 1edd0cee6221..a4579498fc25 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -129,6 +129,14 @@
> Â				};
> Â			};
> Â
> +			adc: adc@1e6e9000 {
> +				compatible = "aspeed,ast2400-adc";
> +				reg = <0x1e6e9000 0xb0>;
> +				clocks = <&syscon ASPEED_CLK_APB>;

We can't do this yet as the clk driver isn't yet merged, and it breaks from the
"just move the node" description in the commit message.

> +				#io-channel-cells = <1>;
> +				status = "disabled";
> +			};
> +
> Â			sram@1e720000 {
> Â				compatible = "mmio-sram";
> Â				reg = <0x1e720000 0x8000>;	// 32K
> @@ -227,14 +235,6 @@
> Â				no-loopback-test;
> Â				status = "disabled";
> Â			};
> -
> -			adc: adc@1e6e9000 {
> -				compatible = "aspeed,ast2400-adc";
> -				reg = <0x1e6e9000 0xb0>;
> -				clocks = <&clk_apb>;
> -				#io-channel-cells = <1>;
> -				status = "disabled";
> -			};
> Â		};
> Â	};
> Â};
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index f56dd67efa50..f6430b313f90 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -173,6 +173,14 @@
> Â				reg-io-width = <4>;
> Â			};
> Â
> +			adc: adc@1e6e9000 {
> +				compatible = "aspeed,ast2500-adc";
> +				reg = <0x1e6e9000 0xb0>;

Did you intend to change the size cell value here? It now matches the g4, but
there was an explicit comment about the size for some reason in the -hunk
below. It's probably worth an explicit call-out if we're going to change it.Â

> +				clocks = <&syscon ASPEED_CLK_APB>;

See the clk comment on the g4 diff.

Cheers,

Andrew

> +				#io-channel-cells = <1>;
> +				status = "disabled";
> +			};
> +
> Â			sram@1e720000 {
> Â				compatible = "mmio-sram";
> Â				reg = <0x1e720000 0x9000>;	// 36K
> @@ -307,14 +315,6 @@
> Â				no-loopback-test;
> Â				status = "disabled";
> Â			};
> -
> -			adc: adc@1e6e9000 {
> -				compatible = "aspeed,ast2500-adc";
> -				reg = <0x1e6e9000 0xb0>;
> -				clocks = <&clk_apb>;
> -				#io-channel-cells = <1>;
> -				status = "disabled";
> -			};
> Â		};
> Â	};
> Â};

Attachment: signature.asc
Description: This is a digitally signed message part