Re: [PATCH] fsl/fman: remove of_node

From: David Miller
Date: Wed Oct 04 2017 - 00:44:04 EST


From: Madalin-cristian Bucur <madalin.bucur@xxxxxxx>
Date: Tue, 3 Oct 2017 08:49:31 +0000

> My patch removes the of_node that was set to a device that was not an
> of_device, preventing duplicated probing of both the real of_device
> and the "fake" one created through this assignment.
>
> I understand that the DSA issue that triggered the initial change
> was related to DSA finding the network devices using
> of_find_net_device_by_node(), something that will not work for the
> DPAA case where the netdevice does not have an of_node. I do not know
> enough about DSA to come up with a solution for this problem now.
> Andrew, Florian, can you please comment on this?

It sounds like you're knowingly breaking DSA.