Re: [PATCH 3/4] staging: bcm2835-camera: pr_err() strings should end with newlines

[Stefan Wahren]

Am 03.10.2017 um 13:43 schrieb Arvind Yadav:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>

Acked-by: Stefan Wahren <stefan.wahren@xxxxxxxx>

> ---
>  drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> index 4360db6..6ea7fb0 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> @@ -1963,7 +1963,7 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance)
>  
>  	status = vchi_service_close(instance->handle);
>  	if (status != 0)
> -		pr_err("mmal-vchiq: VCHIQ close failed");
> +		pr_err("mmal-vchiq: VCHIQ close failed\n");
>  
>  	mutex_unlock(&instance->vchiq_mutex);
>