Re: [PATCH] tty: vt: remove multi-fetch, derive font.height from

From: Greg KH
Date: Wed Oct 04 2017 - 04:22:30 EST

On Sun, Sep 24, 2017 at 12:59:42PM -0400, Meng Xu wrote:
> In con_font_set(), when we need to guess font height (for
> compat reasons?), the current approach uses multiple userspace
> fetches, i.e., get_user(tmp, &charmap[32*i+h-1]), to derive
> the height. This has two drawbacks:
> 1. performance: accessing userspace memory is less efficient than
> directly de-reference the byte
> 2. security: a more critical problem is that the height derived
> might not match with the actual This is because a user
> thread might race condition to change the memory of op->data after
> the op->height guessing but before the second fetch: =
> memdup_user(op->data, size). Leaving font.height = 32 while the
> actual height is 1 or vice-versa.
> This patch tries to resolve both issues by re-locating the height
> guessing part after the is fetched in. In this way, the
> userspace data is fetched in one shot and we directly dereference
> the in kernel space to probe for the height.
> Signed-off-by: Meng Xu <mengxu.gatech@xxxxxxxxx>
> ---
> drivers/tty/vt/vt.c | 48 ++++++++++++++++++++++++++++--------------------
> 1 file changed, 28 insertions(+), 20 deletions(-)

Please always run your patches through so that you don't
get a grumpy maintainer telling you to use :(

Can you fix the obvious issues up and resend?


greg k-h