Re: [PATCH v5 2/2] staging: ion: create one device entry per heap
From: Mark Brown
Date: Wed Oct 04 2017 - 06:17:38 EST
On Tue, Oct 03, 2017 at 04:08:30PM -0700, Sandeep Patil wrote:
> It is entirely possible and easy in android/ueventd to create those nodes
> under "/dev/ion/". (assuming the heap 'subsystem' for these new devices will
> point to 'ion').
The reason I didn't say /dev/ion/foo initially is that if people want to
keep the existing /dev/ion around for compatibility reasons then the
/dev/ion name isn't available which might cause issues. Otherwise just
dumping everything under a directory (perhaps with a different name) was
my first thought as well.
> (Also FWIW, the SELinux permissions are also possible with the current ion
> implementation by adding rules to disallow specific ioctls instead of adding
> permissions to access device node as this change would do)
AIUI the request is to limit access to specific heaps, and obviously not
everyone wants to deal with SELinux at all.
Attachment:
signature.asc
Description: PGP signature