Re: [PATCH v10 3/7] edac,soc: thunderx: Add wrapper for EDAC LMC PCI device
From: Borislav Petkov
Date: Wed Oct 04 2017 - 06:34:52 EST
On Mon, Oct 02, 2017 at 05:17:56PM +0200, Jan Glauber wrote:
> I went for this as the simplest solution, the probing is completely
> synchronous and no state needs to be stored in the wrapper.
What state would you need to store? The wrapper simply gives out the
struct pci_dev * to the callers or NULL if not present.
> 1. What will trigger probing the edac (or perf) driver part?
> Right now the trigger is the PCI device ID. If the wrapper
> does not call into edac how should we load the ThunderX edac/perf drivers?
> The only option I see is a initcall in edac/perf to look for their devices.
The wrapper loads on the PCI dev ID. EDAC loads later and calls the
wrapper function to get the struct pci_dev *. Simple.
> 2. The probe & register is _very_ specific to perf/edac and very different.
> The only part that would fit in the wrapper is pci_enable_device().
> So is that what you have in mind?
No, see above. Instead of getting the PCI device IDs from the PCI core,
you use the wrapper, which gets those from the PCI core. Thus it is
called a "wrapper". :)
Good mailing practices for 400: avoid top-posting and trim the reply.