Re: [PATCH 1/2] ARM: dts: aspeed: Remove undocumented wdt properties

[Andrew Jeffery]

On Wed, 2017-10-04 at 19:46 +1030, Joel Stanley wrote:
> The watchdog bindings do not describe an interrupt property nor clock
> phandle, and the upstream driver never had code to use them. Drop them
> from the device tree.
>Â
> Also rename the node from wdt the more commonly used watchdog.
>Â
> Signed-off-by: Joel Stanley <joel@xxxxxxxxx>

Reviewed-by: Andrew Jeffery <andrew@xxxxxxxx>

> ---
> Âarch/arm/boot/dts/aspeed-g4.dtsi | 7 ++-----
> Âarch/arm/boot/dts/aspeed-g5.dtsi | 8 +++-----
> Â2 files changed, 5 insertions(+), 10 deletions(-)
>Â
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index e455bd236798..5be2e6a39917 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -204,17 +204,14 @@
> Â				status = "disabled";
> Â			};
> Â
> -			wdt1: wdt@1e785000 {
> +			wdt1: watchdog@1e785000 {
> Â				compatible = "aspeed,ast2400-wdt";
> Â				reg = <0x1e785000 0x1c>;
> -				interrupts = <27>;
> Â			};
> Â
> -			wdt2: wdt@1e785020 {
> +			wdt2: watchdog@1e785020 {
> Â				compatible = "aspeed,ast2400-wdt";
> Â				reg = <0x1e785020 0x1c>;
> -				interrupts = <27>;
> -				clocks = <&clk_apb>;
> Â				status = "disabled";
> Â			};
> Â
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 77dded187d5a..71e1264b81aa 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -248,20 +248,18 @@
> Â				status = "disabled";
> Â			};
> Â
> -			wdt1: wdt@1e785000 {
> +			wdt1: watchdog@1e785000 {
> Â				compatible = "aspeed,ast2500-wdt";
> Â				reg = <0x1e785000 0x20>;
> -				interrupts = <27>;
> Â			};
> Â
> -			wdt2: wdt@1e785020 {
> +			wdt2: watchdog@1e785020 {
> Â				compatible = "aspeed,ast2500-wdt";
> Â				reg = <0x1e785020 0x20>;
> -				interrupts = <27>;
> Â				status = "disabled";
> Â			};
> Â
> -			wdt3: wdt@1e785040 {
> +			wdt3: watchdog@1e785040 {
> Â				compatible = "aspeed,ast2500-wdt";
> Â				reg = <0x1e785040 0x20>;
> Â				status = "disabled";

Attachment: signature.asc
Description: This is a digitally signed message part