Re: [PATCH v3 1/7] KEYS: don't let add_key() update an uninstantiated key

From: David Howells
Date: Wed Oct 04 2017 - 10:34:37 EST


Eric Biggers <ebiggers3@xxxxxxxxx> wrote:

> + if ((key->flags & ((1 << KEY_FLAG_INVALIDATED) |
> + (1 << KEY_FLAG_REVOKED) |
> + (1 << KEY_FLAG_INSTANTIATED))) !=
> + (1 << KEY_FLAG_INSTANTIATED)) {

Does this need READ_ONCE(), I wonder?

David