Re: [PATCH 0/1] XDP Program for Ip forward

From: Jesper Dangaard Brouer
Date: Wed Oct 04 2017 - 11:08:04 EST

First of all thank you for working on this.

On Tue, 3 Oct 2017 13:07:04 +0530 cjacob <Christina.Jacob@xxxxxxxxxx> wrote:

> Usage: ./xdp3 [-S] <ifindex1...ifindexn>
> -S to choose generic xdp implementation
> [Default is driver xdp implementation]
> ifindex - the index of the interface to which
> the xdp program has to be attached.
> in 4.14-rc3 kernel.

I would prefer if we can name the program something more descriptive
than "xdp3". What about "xdp_redirect_router" or "xdp_router_ipv4" ?

I would also appreciate if we can stop using ifindex'es, and instead
use normal device ifname's. And simply do the lookup to the ifindex in
the program via if_nametoindex(ifname), see how in [1] and [2].

When adding more ifname's you can just use the same trick as with
multiple --cpu options like [1] and [2].


Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat