Re: [RFC PATCH 1/2] kbuild: Pass HOSTCC and similar to tools Makefiles

From: Doug Anderson
Date: Wed Oct 04 2017 - 12:09:59 EST


Hi,

On Tue, Oct 3, 2017 at 9:07 PM, Guenter Roeck <groeck@xxxxxxxxxx> wrote:
> On Tue, Oct 3, 2017 at 8:20 PM, Masahiro Yamada
>> CC: for building tools that run on the target machine
>> HOSTCC: for building tools that run on the build machine
>>
>>
>> IMHO, this should be consistent to avoid confusion.
>>
>>
>> Grepping CROSS_COMPILE under tools/ directory,
>> I see many Makefile expect CC for the target system.
>>
>> For ex, tools/croup/Makefile
>>
>> CC = $(CROSS_COMPILE)gcc
>>
>>
>>
>> Why don't you fix tools/objtool/Makefile ?
>>
>>
>
> Interesting question. You are right, most tools are target tools, not
> host tools. Maybe it _would_ make sense to use HOSTCC/HOSTCFLAGS to
> build it. Copying Josh for input.

Ah, good point. I'm not terribly familiar with the things under
tools, so when I saw "objtool" I assumed it was following a standard
pattern for tools.

I can submit a patch for objtool's Makefile. ...or, if it makes more
sense, I can submit a patch to move "objtool" to the scripts
directory. ...or I can butt out of it. :) Which would folks prefer?

-Doug