Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe
From: Julia Lawall
Date: Wed Oct 04 2017 - 13:08:04 EST
On Wed, 4 Oct 2017, Srishti Sharma wrote:
> On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote:
> >> Again, you have three patches on different files with the same subject
> >> line. You could add the file name eg rtw_ap: to the subject line to make
> >> them unique.
> >>
> >
> > And the subject needs to start with [PATCH v3] and then after the
> > Signed off by line put:
> Shouldn't it be only v2 as I haven't sent a v2 for this before.
It should be ok. There was a v1 that only did list_entry and where all
the patches had the same subject, but Greg already dropped that one.
julia
>
> Regards,
> Srishti
> >
> > ---
> > v2 and v3: Changes to the subjects and changelogs.
> >
> > regards,
> > dan carpenter
>