Re: [PATCH 2/2] selinux: fix build warning

From: Stephen Smalley
Date: Wed Oct 04 2017 - 16:32:23 EST


On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
> This patch make selinux_task_prlimit() static since it is not used
> anywhere else.
> This fix the following build warning:
> security/selinux/hooks.c:3981:5: warning: no previous prototype for
> 'selinux_task_prlimit' [-Wmissing-prototypes]
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>

Acked-by: Stephen Smalley <sds@xxxxxxxxxxxxx>

> ---
> Âsecurity/selinux/hooks.c | 4 ++--
> Â1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 8507a56f85e4..b8a022f4b4a7 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3977,8 +3977,8 @@ static int selinux_task_getioprio(struct
> task_struct *p)
> Â ÂÂÂÂPROCESS__GETSCHED, NULL);
> Â}
> Â
> -int selinux_task_prlimit(const struct cred *cred, const struct cred
> *tcred,
> - Âunsigned int flags)
> +static int selinux_task_prlimit(const struct cred *cred, const
> struct cred *tcred,
> + unsigned int flags)
> Â{
> Â u32 av = 0;
> Â