Re: [PATCH v2 2/9] ARM: dts: aspeed: Reorder ADC node

[Andrew Jeffery]

On Wed, 2017-10-04 at 17:19 +1030, Joel Stanley wrote:
> We try to keep the nodes in address order. The ADC node was out of
> place.
>Â
> Signed-off-by: Joel Stanley <joel@xxxxxxxxx>

Reviewed-by: Andrew Jeffery <andrew@xxxxxxxx>

>Â
> ---
> v2:
> Â- Don't introduce new clk bindings
> ---
> Âarch/arm/boot/dts/aspeed-g4.dtsi | 16 ++++++++--------
> Âarch/arm/boot/dts/aspeed-g5.dtsi | 16 ++++++++--------
> Â2 files changed, 16 insertions(+), 16 deletions(-)
>Â
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index 1edd0cee6221..c2d96b8a5065 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -129,6 +129,14 @@
> Â				};
> Â			};
> Â
> +			adc: adc@1e6e9000 {
> +				compatible = "aspeed,ast2400-adc";
> +				reg = <0x1e6e9000 0xb0>;
> +				clocks = <&clk_apb>;
> +				#io-channel-cells = <1>;
> +				status = "disabled";
> +			};
> +
> Â			sram@1e720000 {
> Â				compatible = "mmio-sram";
> Â				reg = <0x1e720000 0x8000>;	// 32K
> @@ -227,14 +235,6 @@
> Â				no-loopback-test;
> Â				status = "disabled";
> Â			};
> -
> -			adc: adc@1e6e9000 {
> -				compatible = "aspeed,ast2400-adc";
> -				reg = <0x1e6e9000 0xb0>;
> -				clocks = <&clk_apb>;
> -				#io-channel-cells = <1>;
> -				status = "disabled";
> -			};
> Â		};
> Â	};
> Â};
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index f56dd67efa50..9e71c2dac0ba 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -173,6 +173,14 @@
> Â				reg-io-width = <4>;
> Â			};
> Â
> +			adc: adc@1e6e9000 {
> +				compatible = "aspeed,ast2500-adc";
> +				reg = <0x1e6e9000 0xb0>;
> +				clocks = <&clk_apb>;
> +				#io-channel-cells = <1>;
> +				status = "disabled";
> +			};
> +
> Â			sram@1e720000 {
> Â				compatible = "mmio-sram";
> Â				reg = <0x1e720000 0x9000>;	// 36K
> @@ -307,14 +315,6 @@
> Â				no-loopback-test;
> Â				status = "disabled";
> Â			};
> -
> -			adc: adc@1e6e9000 {
> -				compatible = "aspeed,ast2500-adc";
> -				reg = <0x1e6e9000 0xb0>;
> -				clocks = <&clk_apb>;
> -				#io-channel-cells = <1>;
> -				status = "disabled";
> -			};
> Â		};
> Â	};
> Â};

Attachment: signature.asc
Description: This is a digitally signed message part