Re: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver
From: Andy Shevchenko
Date: Thu Oct 05 2017 - 01:29:17 EST
On Thu, Oct 5, 2017 at 4:09 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> On Wed, Oct 04, 2017 at 05:48:31PM -0500, Mario Limonciello wrote:
>> All communication on individual GUIDs should occur in separate drivers.
>> Allowing a driver to communicate with the bus to another GUID is just
>> a hack that discourages drivers to adopt the bus model.
>> The information found from the WMI descriptor driver is now exported
>> for use by other drivers.
> You'll want to add something like:
> #ifdef CONFIG_DELL_WMI_DESCRIPTOR_MODULE
> if (request_module("dell_wmi_descriptor"))
> /* FAIL */
> During init.
I don't think #ifdef is needed.
We may just request module.
But looking in the code it seems that we simple need to select that
module. No request_module will be needed.
Did I miss something?
With Best Regards,