Re: [PATCH 1/8] pinctrl: meson: remove offset from pinctrl
From: Jerome Brunet
Date: Thu Oct 05 2017 - 07:47:58 EST
On Thu, 2017-10-05 at 13:22 +0200, Linus Walleij wrote:
> On Wed, Sep 20, 2017 at 3:39 PM, Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:
> > Offset on meson pinctrl and gpios is something that was carried from the
> > vendor driver, where there is a weird link between the 2
> > controllers. Since these 2 controllers are independent, this offset adds
> > an unnecessary complexity.
> > This patch remove this manually set offset and rely on pinctrl to figure
> > out the gpio base offset
> > Tested-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> > Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> Patch applied.
Just to be sure, did you remember to squash patch 1 to 5 together ?
I know it is a bit unusual but, as explained earlier, those patches were only
split to ease the review. Keeping the change split would break bisect.
> Linus Walleij