Re: [PATCH] RDMA/nes: Convert timers to use timer_setup()
From: Thomas Gleixner
Date: Thu Oct 05 2017 - 09:49:11 EST
On Thu, 5 Oct 2017, Doug Ledford wrote:
> On 10/4/2017 8:45 PM, Kees Cook wrote:
> > In preparation for unconditionally passing the struct timer_list pointer to
> > all timer callbacks, switch to using the new timer_setup() and from_timer()
> > to pass the timer pointer explicitly. A pointer from nesadapter back to
> > nesdev was added.
> > Cc: Faisal Latif <faisal.latif@xxxxxxxxx>
> > Cc: Doug Ledford <dledford@xxxxxxxxxx>
> > Cc: Sean Hefty <sean.hefty@xxxxxxxxx>
> > Cc: Hal Rosenstock <hal.rosenstock@xxxxxxxxx>
> > Cc: linux-rdma@xxxxxxxxxxxxxxx
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > ---
> > This requires commit 686fef928bba ("timer: Prepare to change timer
> > callback argument type") in v4.14-rc3, but should be otherwise
> > stand-alone.
> What is your intention with this, and the other RDMA related, patches?
> Is it your intention that I should pick these up or is someone else
> supposed to (you sent it to linux-kernel and only Cc:ed linux-rdma)?
> Also, are you intending this to go into -rc? If so, why is it dependent
> on a patch that didn't land until -rc3?
That's 4.15 material and should preferrably be picked up by the relevant
maintainers. The 4.14-rc3 reference is there just in case a maintainer tree
is based on pre 4.14-rc3, so applying the patch would break the build.