Re: [PATCH V9 13/15] mmc: block: Add CQE and blk-mq support
From: Bartlomiej Zolnierkiewicz
Date: Thu Oct 05 2017 - 10:14:58 EST
On Thursday, October 05, 2017 02:00:48 PM Bartlomiej Zolnierkiewicz wrote:
> > > > I am trying to wrap my head around this large patch. The size makes it
> > > > hard but I am doing my best.
> > >
> > > I also think that this patch should be split on two patches. The 1st one
> > > introducing blk-mq and the 2nd one adding CQE support.
> > >
> > > [ I don't agree that they make more sense together, on the contrary,
> > > it is very difficult to properly analyze blk-mq changes on their
> > > own while there are mixed with CQE related ones. ]
> > The CQE and non-CQE code paths are clearly marked. But maybe you
> The combined patch is > 1 kLOC which is a lot and since the CQE and
> non-CQE code paths are clearly marked it should be really easy to
> split them.
> > are asking what the code would look like if we *never* had to support CQE.
> > And my point is we *do* have to support CQE.
> We *do* but not in the same step, it is just normal kernel engineering
> practice to split patches on logical changes. This is not asking about
> something extraordinary.
I sympathize with you that it takes long time to get CQE merged
upstream and that you weren't told earlier that no new users of
the old block API are welcomed.
However since "mmc-mq" support has to be added as a preparation for
CQE please try do it *properly* and also consider that many people
may want just "mmc-mq" without CQE as their hardware simply doesn't
Samsung R&D Institute Poland