Re: [PATCH v4 08/14] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens

From: Andy Shevchenko
Date: Thu Oct 05 2017 - 10:22:13 EST

On Thu, Oct 5, 2017 at 4:58 PM, <Mario.Limonciello@xxxxxxxx> wrote:

>> > Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>> To be clear I just suggested the output format in ->show() callback.
> Andy, do you mean you would prefer not to be attributed in the description,
> or should I be clearer that was your suggestion?

I think that there is bigger threshold for being included one's name
in Suggested-by tag. You have few dozens of lines changed and only one
is suggested by me. And that one doesn't influence the initial idea,
just a format change.

So, I'm not against it per se, I just think it confuses more than attributes.

Summarize: I would not put it in this patch.

With Best Regards,
Andy Shevchenko