Re: [PATCH 2/3] greybus: audio: don't inclide rwlock.h directly.

From: Mark Greer
Date: Thu Oct 05 2017 - 11:17:34 EST


On Thu, Oct 05, 2017 at 02:56:54PM +0200, Sebastian Andrzej Siewior wrote:
> rwlock.h should not be included directly. Instead linux/splinlock.h
> should be included. One thing it does is to break the RT build.
>
> Cc: Vaibhav Agarwal <vaibhav.sr@xxxxxxxxx>
> Cc: Mark Greer <mgreer@xxxxxxxxxxxxxxx>
> Cc: Johan Hovold <johan@xxxxxxxxxx>
> Cc: Alex Elder <elder@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: greybus-dev@xxxxxxxxxxxxxxxx
> Cc: devel@xxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> drivers/staging/greybus/audio_manager.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
> index aa6508b44fab..045696ce85c7 100644
> --- a/drivers/staging/greybus/audio_manager.c
> +++ b/drivers/staging/greybus/audio_manager.c
> @@ -10,7 +10,7 @@
> #include <linux/sysfs.h>
> #include <linux/module.h>
> #include <linux/init.h>
> -#include <linux/rwlock.h>
> +#include <linux/spinlock.h>
> #include <linux/idr.h>
>
> #include "audio_manager.h"
> --
> 2.14.2

Thanks for the patch.

Reviewed-by: Mark Greer <mgreer@xxxxxxxxxxxxxxx>