Re: [RFC PATCH 0/2] Missing READ_ONCE in core and arch-specific pgtable code leading to crashes
From: Will Deacon
Date: Thu Oct 05 2017 - 12:54:39 EST
On Tue, Oct 03, 2017 at 02:36:42AM -0400, Jon Masters wrote:
> On 09/29/2017 04:56 AM, Will Deacon wrote:
> > The full fix isn't just cosmetic; it's also addressing the wider problem
> > of unannotated racing page table accesses outside of the specific failure
> > case we've run into.
> Let us know if there are additional tests we should be running on the
> Red Hat end. We've got high hundreds of ARM server systems at this
> point, including pretty much everything out there.
TBH, there's nothing ARM-specific about this issue afaict and it should
be reproducible on x86 if the compiler can keep the initially loaded pmd
live in a GPR for long enough.
As for wider problems, you want to stress anything that does page table
modification concurrently with lockless walkers (although GUP looks mostly
ok modulo the lack of pud_trans_huge support, which I'll try to fix if
I find time).