Re: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver

From: Darren Hart
Date: Thu Oct 05 2017 - 13:22:32 EST


On Thu, Oct 05, 2017 at 02:47:15PM +0000, Mario.Limonciello@xxxxxxxx wrote:
> > >
> > > So I believe it should be a mandatory runtime dependency due to needing
> > > the symbol dell_wmi_get_interface_version. Depmod should be handling
> > > this then no?
> >
> > This was nagging me all night, and I was thinking the last time I had to
> > use this it was indeed a runtime dependency. Sorry for the noise on
> > this.
> >
> > The kconfig needs to be setup such that dell-wmi-descriptor cannot be a
> > module if the dependent drivers are modules.
> >
> > --
> > Darren Hart
> > VMware Open Source Technology Center
>
> Even if the others are modules shouldn't module ordering from depmod still DTRT?
> You still won't be able to load dell-wmi.ko until dell-wmi-descriptor.ko was loaded.
>

I worded that wrong *facepalm*, let me try again...

The kconfig needs to be setup such that dell-wmi-descriptor cannot be a
module if the dependent drivers are built-in.

--
Darren Hart
VMware Open Source Technology Center