Re: [PATCH] powerpc: Default to enabling STRICT_KERNEL_RWX
From: Kees Cook
Date: Thu Oct 05 2017 - 14:58:49 EST
On Thu, Oct 5, 2017 at 11:57 AM, christophe leroy
<christophe.leroy@xxxxxx> wrote:
>
>
> Le 05/10/2017 Ã 19:30, Kees Cook a Ãcrit :
>>
>> On Thu, Oct 5, 2017 at 12:49 AM, Christophe LEROY
>> <christophe.leroy@xxxxxx> wrote:
>>>
>>>
>>>
>>> Le 05/10/2017 Ã 05:45, Kees Cook a Ãcrit :
>>>>
>>>>
>>>> When available, CONFIG_KERNEL_RWX should be default-enabled.
>>>
>>>
>>>
>>> On PPC32, this option implies deactivating BATs and/or LTLB mapping of
>>> the
>>> linear kernel address space, hence a significant performance degradation.
>>>
>>> So at least on PPC32, it should remain unselected by default.
>>
>>
>> Alright, sounds fine to me. Would this be okay?
>>
>> + select ARCH_OPTIONAL_KERNEL_RWX_DEFAULT if !PPC64
>
>
> You mean
>
> select ARCH_OPTIONAL_KERNEL_RWX_DEFAULT if PPC64
>
> Don't you ?
Oops, yes! :)
-Kees
--
Kees Cook
Pixel Security