Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

From: Jens Axboe
Date: Thu Oct 05 2017 - 15:49:46 EST

On 10/05/2017 01:41 PM, Jens Axboe wrote:
> On 10/05/2017 01:23 PM, Thomas Gleixner wrote:
>> On Thu, 5 Oct 2017, Jens Axboe wrote:
>>> On 10/05/2017 11:49 AM, Kees Cook wrote:
>>>> Yes, totally true. tglx and I ended up meeting face-to-face at the
>>>> Kernel Recipes conference and we solved some outstanding design issues
>>>> with the conversion. The timing meant the new API went into -rc3,
>>>> which seemed better than missing an entire release cycle, or carrying
>>>> deltas against maintainer trees that would drift. (This is actually my
>>>> second massive refactoring of these changes...)
>>> Honestly, I think the change should have waited for 4.15 in that case.
>>> Why the rush? It wasn't ready for the merge window.
>> Come on. You know very well that a prerequisite for global changes which is
>> not yet used in Linus tree can get merged post merge windew in order to
>> avoid massive inter maintainer tree dependencies. We've done that before.
> My point is that doing it this late makes things harder than they should
> have been. If this was in for -rc1, it would have made things a lot
> easier. Or even -rc2. I try and wait to fork off the block tree for as
> long as I can, -rc2 is generally where that happens.

Timing of the change aside, this patch doesn't even apply to the 4.15
block tree:

checking file block/blk-core.c
checking file include/linux/writeback.h
Hunk #1 succeeded at 309 (offset -20 lines).
checking file mm/page-writeback.c
Hunk #1 FAILED at 1977.
Hunk #2 FAILED at 1988.
2 out of 2 hunks FAILED

Jens Axboe