Re: [PATCH 1/2] powerpc/platforms/cell: Delete an error message for a failed memory allocation in three functions

From: Michal SuchÃnek
Date: Thu Oct 05 2017 - 16:02:18 EST


On Thu, 5 Oct 2017 21:36:26 +0200
SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:

> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 5 Oct 2017 21:04:30 +0200
> Omit extra messages for a memory allocation failure in these
> functions.

this is bogus. All these functions return -1 on any error. Until they
reflect the error in their return value (and it is properly propagated
to the user) there is no way to tell WTF failed without the message.

> This issue was detected by using the Coccinelle software.

... which provides only a hint which should be evaluated by the user.