Re: [PATCH 8/8] ktest: Use config-bisect.pl in ktest.pl
From: Steven Rostedt
Date: Thu Oct 05 2017 - 19:43:54 EST
On Thu, 05 Oct 2017 18:18:54 -0500
Scott Wood <swood@xxxxxxxxxx> wrote:
> On Thu, 2017-10-05 at 08:50 -0400, Steven Rostedt wrote:
> > On Wed, 04 Oct 2017 15:24:23 -0500
> > Scott Wood <swood@xxxxxxxxxx> wrote:
> > > It should also be noted that ktest.pl only depends on config-
> > > bisect.pl
> > > if a config bisect is being performed, so other ktest.pl functions
> > > still
> > > work standalone.
> > I thought about this too, and may be able to live with that. Perhaps
> > we
> > should make the config-bisect internals into something that can be a
> > perl library, and be able to place that someplace that both could use?
> I'm not familiar with how Perl libraries work -- how would they solve
> this problem? If you're talking about having to install the library
> into some location outside the kernel tree, that seems contrary to the
> desire to have a lightweight tool that can be copied around. If not,
> how would it be any better than depending on a callable script?
I'm thinking about installing it in the tree, and then using variables
to find it. I'm not sure how perl works either, but as an interpreted
language, I'm sure there's gotta be a way to add default paths to look
for it. Perhaps there's a way to include other perl scripts.
I'll have to play around with this to come up with better ideas.