Re: [PATCH] lightnvm: pblk: remove spinlock when freeing line metadata

From: Javier GonzÃlez
Date: Fri Oct 06 2017 - 09:28:57 EST

> On 6 Oct 2017, at 11.20, Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx> wrote:
> On 10/05/2017 11:35 AM, Hans Holmberg wrote:
>> From: Hans Holmberg <hans.holmberg@xxxxxxxxxxxx>
>> Lockdep complains about being in atomic context while freeing line
>> metadata - and rightly so as we take a spinlock and end up calling
>> vfree that might sleep(in pblk_mfree).
>> There is no need for holding the line manager free_lock while
>> freeing line metadata, so remove the lock.
>> Signed-off-by: Hans Holmberg <hans.holmberg@xxxxxxxxxxxx>
> Reviewed-by: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
> I guess this also deserves stable tag. The bug was introduced in 4.13 by
> commit 588726d3ec68 ("lightnvm: pblk: fail gracefully on irrec. error").

Good point. We'll add it when picking it up.


Attachment: signature.asc
Description: Message signed with OpenPGP