Re: [PATCH] kmemleak: change /sys/kernel/debug/kmemleak permissions from 0444 to 0644

[Catalin Marinas]

On Fri, Oct 06, 2017 at 02:39:25PM +0300, Konstantin Khlebnikov wrote:
> Kmemleak could be tweaked in runtime by writing commands into debugfs file.
> Root anyway can use it, but without write-bit this interface isn't obvious.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxxxxxx>
> ---
>  mm/kmemleak.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index 7780cd83a495..fca3452e56c1 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -2104,7 +2104,7 @@ static int __init kmemleak_late_init(void)
>  		return -ENOMEM;
>  	}
>  
> -	dentry = debugfs_create_file("kmemleak", S_IRUGO, NULL, NULL,
> +	dentry = debugfs_create_file("kmemleak", 0644, NULL, NULL,
>  				     &kmemleak_fops);
>  	if (!dentry)
>  		pr_warn("Failed to create the debugfs kmemleak file\n");

Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>

-- 
Catalin