Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef

From: Michael Chan
Date: Fri Oct 06 2017 - 21:27:49 EST

Next message: Jia-Ju Bai: "[BUG] fs/aio: A possible sleep-in-atomic bug in aio_migratepage"
Previous message: Ed Swierk: "Which came first, hard kernel lockup or SATA errors?"
In reply to: Jonathan Toppins: "[PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef"
Next in thread: David Miller: "Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins <jtoppins@xxxxxxxxxx> wrote:
> There is no reason to wrap the data structures inside the ifdef.

What's so bad about wrapping unused data structures inside #ifdef?
These structures are only used if CONFIG_BNXT_FLOWER_OFFLOAD is
defined.

Next message: Jia-Ju Bai: "[BUG] fs/aio: A possible sleep-in-atomic bug in aio_migratepage"
Previous message: Ed Swierk: "Which came first, hard kernel lockup or SATA errors?"
In reply to: Jonathan Toppins: "[PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef"
Next in thread: David Miller: "Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]