Re: [RESEND PATCH] gpio: omap: Fix lost edge interrupts

[santosh.shilimkar@xxxxxxxxxx]

On 10/7/17 4:18 AM, Linus Walleij wrote:
> On Tue, Oct 3, 2017 at 6:17 PM, Grygorii Strashko
> <grygorii.strashko@xxxxxx> wrote:
>
> > Now acking of edge irqs happens the following way:
> > - omap_gpio_irq_handler
> >    - "isr" = read irq status
> >    - omap_clear_gpio_irqbank(bank, isr_saved & ~level_mask);
> >          ^ clear edge status, so irq can be accepted
> >    - loop while "isr"
> >          generic_handle_irq()
> >           - handle_edge_irq()
> >              - desc->irq_data.chip->irq_ack(&desc->irq_data);
> >                  - omap_gpio_ack_irq()
> > it might be that at this moment edge IRQ was triggered again and it will be
> > cleared and IRQ will be lost.
> >
> > Use handle_simple_irq and clear edge interrupts early without disabling them in
> > omap_gpio_irq_handler to avoid loosing interrupts.
> >
> > [1] https://urldefense.proofpoint.com/v2/url?u=https-3A__marc.info_-3Fl-3Dlinux-2Domap-26m-3D149004465313534-26w-3D2&d=DwIBaQ&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=XBn1JQGPwR8CsE7xpP3wPlG6DQU7qw8ym65xieNZ4hY&m=GC9UD4RPcq1Ss-JanXn4japAFhT1w4RZlq9WqDLSw_o&s=smHFYjIN3O5THK4qP413bHMnr8PaWUv4xyUbbTwXHk4&e=

This link doesn't need to be part of the changelog.

> > Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
> > Signed-off-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx>
>
> Patch applied for fixes.
>
> I guess it is the right thing to do?
>
> Other maintainers need to tell me if I should hold it back.
Am fine with it after Grygorii's reasoning.

Regards,
Santosh