Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

From: Masahiro Yamada
Date: Sun Oct 08 2017 - 09:40:47 EST


2017-09-22 6:54 GMT+09:00 David Daney <ddaney@xxxxxxxxxxxxxxxxxx>:
> On 09/13/2017 07:37 PM, Masahiro Yamada wrote:
>>
>> This driver implements .alloc() hook, so .map() is not used.
>
>
> Although this comment is true for this driver, it is unclear to me if the
> statement is true in the general case.

If a driver implements .alloc() hook,
irq_domain_check_hierarchy() sets IRQ_DOMAIN_FLAG_HIERARCHY flag.


If you see kernel/irq/irqdomain.c,
alloc/map is selected by irq_domain_is_hierarchy().



--
Best Regards
Masahiro Yamada