Re: [PATCH] skd: Use kmem_cache_free

[Bart Van Assche]

On Mon, 2017-10-09 at 03:00 +0530, Himanshu Jha wrote:
> Use kmem_cache_free instead of kfree for freeing the memory previously
> allocated with kmem_cache_zalloc/kmem_cache_alloc/kmem_cache_node.
> 
> Signed-off-by: Himanshu Jha <himanshujha199640@xxxxxxxxx>
> ---
>  drivers/block/skd_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> index 7cedb42..64d0fc1 100644
> --- a/drivers/block/skd_main.c
> +++ b/drivers/block/skd_main.c
> @@ -2604,7 +2604,7 @@ static void *skd_alloc_dma(struct skd_device *skdev, struct kmem_cache *s,
>  		return NULL;
>  	*dma_handle = dma_map_single(dev, buf, s->size, dir);
>  	if (dma_mapping_error(dev, *dma_handle)) {
> -		kfree(buf);
> +		kmem_cache_free(s, buf);
>  		buf = NULL;
>  	}
>  	return buf;

Thanks for this patch.

Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxx>