Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks

[Michael S. Tsirkin]

On Mon, Oct 09, 2017 at 03:07:42PM +0000, Bart Van Assche wrote:
> On Mon, 2017-10-09 at 16:22 +0300, Michael S. Tsirkin wrote:
> > On Fri, Oct 06, 2017 at 10:23:53AM -0700, Bart Van Assche wrote:
> > > The purpose of patch "linux/types.h: enable endian checks for all
> > > sparse builds" was to encourage driver authors to annotate
> > > endianness correctly in their drivers. However, since that patch
> > > went upstream no endianness annotations in drivers have been fixed.
> > > I think that this shows that the followed approach does not work,
> > > probably because several driver authors do not use sparse. Restore
> > > the ability to disable sparse endianness checks such that it
> > > becomes again easy to review other sparse diagnostics for people
> > > who want to analyze drivers they are not the author of.
> > > 
> > > References: commit 05de97003c77 ("linux/types.h: enable endian checks for all sparse builds")
> > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> > > Cc: Christoph Hellwig <hch@xxxxxx>
> > > Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > 
> > I still think the new default is good.  You probably want ability to
> > disable these checks selectively for the specific drivers though. Makes
> > it easier to spot what needs to be fixed.
> 
> Hello MST,
> 
> I agree with what you wrote. And what you described is what my patch implements
> - keep endianness checking enabled by default and make it possible to disable it
> selectively. Does that mean that you agree with the patch I posted?
> 
> Thanks,
> 
> Bart.

I just mean I'd expect a patchset setting the flag for the broken
drivers. Presumably this will help trigger some action.

-- 
MST