Re: [PATCH] net: can: Convert timers to use timer_setup()

From: Kees Cook
Date: Mon Oct 09 2017 - 14:09:30 EST


On Mon, Oct 9, 2017 at 10:53 AM, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> On 10/05/2017 02:51 AM, Kees Cook wrote:
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to pass the timer pointer explicitly.
>>
>> Cc: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
>> Cc: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
>> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
>> Cc: linux-can@xxxxxxxxxxxxxxx
>> Cc: netdev@xxxxxxxxxxxxxxx
>> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>> ---
>> This requires commit 686fef928bba ("timer: Prepare to change timer
>> callback argument type") in v4.14-rc3, but should be otherwise
>> stand-alone.
>
> Are you taking the patch or should I apply it?
>
> Acked-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>

If you have -rc3 in your tree, please take it. If you want the timers
tree to carry it instead, we can do that too.

Thanks!

-Kees

--
Kees Cook
Pixel Security