Re: [PATCH] direct-io: Prevent NULL pointer access in submit_page_section

From: Andreas Gruenbacher
Date: Mon Oct 09 2017 - 14:24:12 EST


On 9 October 2017 at 18:22, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Oct 09, 2017 at 11:13:18AM +0200, Andreas Gruenbacher wrote:
>> In the code added to function submit_page_section by commit b1058b981,
>> sdio->bio can currently be NULL when calling dio_bio_submit. This then
>> leads to a NULL pointer access in dio_bio_submit, so check for a NULL
>> bio in submit_page_section before trying to submit it instead.
>>
>> Fixes xfstest generic/250 on gfs2.
>>
>> Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
>> Reviewed-by: Jan Kara <jack@xxxxxxx>
>
> How far back in -stable should it go? I'm fine with the patch, but I'd
> rather have accurate Cc: stable in commit message...

The bug was introduced in 3.10, and apart from a trivial conflict with:

09cbfeaf1a5a mm, fs: get rid of PAGE_CACHE_* and
page_cache_{get,release} macros

from v4.6, it applies up to v3.10.

The conflict is in the diff context: page_cache_release has been
replaced by put_page.

Thanks,
Andreas